fix(form-field): correct prefix & suffix icons as well as select arrow for various form field appearances #9743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mmalerba
changed the title
jelbourn
added
pr: lgtm
action: merge
mmalerba
added a commit
that referenced
this pull request
Feb 2, 2018
…w for various form field appearances (#9743)
mmalerba
added a commit
that referenced
this pull request
Feb 4, 2018
…w for various form field appearances (#9743)
mmalerba
added a commit
that referenced
this pull request
Feb 6, 2018
…ter (#9762) * feat(form-field): support for different spec variants (#9366) * feat(form-field): implement hover state [Based on the spec](https://material.io/guidelines/components/text-fields.html#text-fields-states) form fields should have a hover state where the underline gets darkened while the user is hovering and gets replaced by the theme color after the focus the input. * branch css logic * extract underline css into standard variant * box variant underline * box variant spacing * add legacy variant * fix select ellipsis * move hover state changes out of legacy variant * add variants section to input demo * use filter/backface-visibility to address label jumpiness * address comments * fix box variant text fuzziness * remove bluriness fixes that aren't needed anymore * address comments * remove the floatLabel=never option in the new variants * variant --> appearance * add tests for new label & placeholder behavior * update demo to use mat-label * fix bazel build * feat(chips): Add chip avatar and chip trailing icon (#9557) * feat(chips): Add chip avatar and chip trailing icon * Removed MatBasicChip and MatStandardChip * Add mat-chip-trailing-icon style to MatChipRemove and add examples in demo * fix(form-field): rename box to fill and tweak the styles a bit (#9636) * make some tweaks to the box appearance * rename 'box' appearance to 'fill' * feat(form-field): add outline style (#9705) * remove datepicker reliance on form-field's underlineRef * add spacing and alignment rules for outline variant * outline color & thickness * style tweaks * correctly position and size the gap * address comments * fix(form-field): correct prefix & suffix icons as well as select arrow for various form field appearances (#9743) * feat(input): add utilities for custom styling and monitoring state of input autofill (#9719) * add utility for monitoring input autofill * add scss mixin for styling input autofill colors * tests * move everything from cdk to MatInputModule * address comments * add doc comments * fix(form-field): fixes for outline appearance (#9759) * use the `AutofillMonitor` in `MatInput` * Make `updateOutlineGap` public so users can call it if needed * feat(chips): add ripple to chips (#9761) * fix(form-field, chips): fix tests & lint (#9767) * undo change that caused darkened color for legacy form field * fix change detection * fix(chips): remove margin for chip list (#9793) * add terminateOnPointerUp to ripple config
|
The .mat-icon-button still has the icon with font-size: 16px (inherited from input), which is too small, should be 24px. See here the guidelines: |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
legacy - https://mmalerba-demo1.firebaseapp.com/input
standard - https://mmalerba-demo2.firebaseapp.com/input
fill - https://mmalerba-demo3.firebaseapp.com/input
outline - https://mmalerba-demo4.firebaseapp.com/input
(Please ignore the text prefix and suffix, those shouldn't be used with the new variants, we need to create some sort of input masking solution to replace them).