fix(selection-list): preselected options not being added to the model value #9116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… value Fixes preselected list options not being added to the model due to: * The `Promise.resolve` inside the `ngOnInit` not actually doing anything due to a missing `.then`. * The option not being added to the selection model when the value is emitted, which means that it won't be a part of the model.
googlebot
added
the
cla: yes
devversion
added
pr: lgtm
action: merge
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 8, 2018
… value (angular#9116) Fixes preselected list options not being added to the model due to: * The `Promise.resolve` inside the `ngOnInit` not actually doing anything due to a missing `.then`. * The option not being added to the selection model when the value is emitted, which means that it won't be a part of the model.
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 9, 2018
… value (angular#9116) Fixes preselected list options not being added to the model due to: * The `Promise.resolve` inside the `ngOnInit` not actually doing anything due to a missing `.then`. * The option not being added to the selection model when the value is emitted, which means that it won't be a part of the model.
jelbourn
pushed a commit
that referenced
this pull request
Jan 9, 2018
… value (#9116) Fixes preselected list options not being added to the model due to: * The `Promise.resolve` inside the `ngOnInit` not actually doing anything due to a missing `.then`. * The option not being added to the selection model when the value is emitted, which means that it won't be a part of the model.
tinayuangao
pushed a commit
that referenced
this pull request
Jan 10, 2018
… value (#9116) Fixes preselected list options not being added to the model due to: * The `Promise.resolve` inside the `ngOnInit` not actually doing anything due to a missing `.then`. * The option not being added to the selection model when the value is emitted, which means that it won't be a part of the model.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes preselected list options not being added to the model due to:
Promise.resolveinside thengOnInitnot actually doing anything due to a missing.then.