Skip to content

fix(autocomplete): panelClosingActions emitting twice in some cases #8998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2017
Merged

fix(autocomplete): panelClosingActions emitting twice in some cases #8998

merged 1 commit into from
Dec 20, 2017

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 14, 2017

Fixes a few CI failures that were introduced after merging multiple refactoring tasks at the same time.

@crisbeto
fix(autocomplete): panelClosingActions emitting twice in some cases
fc3e195 
Fixes a few CI failures that were introduced after merging multiple refactoring tasks at the same time.
@crisbeto crisbeto requested a review from kara as a code owner December 14, 2017 18:05
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 14, 2017
jelbourn
jelbourn approved these changes Dec 15, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 15, 2017
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Dec 16, 2017
@josephperrott josephperrott merged commit 4f97232 into angular:master Dec 20, 2017
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 2, 2018
@crisbeto @josephperrott
fix(autocomplete): panelClosingActions emitting twice in some cases (a…
22c3259 
…ngular#8998)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@kara kara Awaiting requested review from kara

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto @jelbourn @googlebot @josephperrott