Skip to content

fix(expansion): use display rather than visibility to hide closed expansion panels #8820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(expansion): use display rather than visibility to hide closed expansion panels #8820

wants to merge 1 commit into from

Conversation

@josephperrott
Copy link
Member

@josephperrott josephperrott commented Dec 5, 2017

Fixes #8754

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 5, 2017
jelbourn
jelbourn approved these changes Dec 5, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 5, 2017
@josephperrott josephperrott added the target: minor This PR is targeted for the next minor release label Dec 6, 2017
@andrewseguin andrewseguin added the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Dec 13, 2017
@josephperrott josephperrott mentioned this pull request Jan 22, 2018
Closed
@meehol
Copy link

meehol commented Feb 2, 2018

Hey guys, into which version can we expect this to be pulled?

@josephperrott josephperrott mentioned this pull request Feb 13, 2018
Closed
@josephperrott
Copy link
Member Author

josephperrott commented Aug 22, 2018

Closing as this was addressed by #10138

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 9, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
@josephperrott josephperrott deleted the expansion-overflow branch March 20, 2020 22:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@josephperrott josephperrott

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nested Expansion panels keep overflow visible

5 participants

@josephperrott @meehol @jelbourn @googlebot @andrewseguin