fix(overlay): dimension not updated after init #8765

emoralesb05 · 2017-12-01T19:59:41Z

when changing the width of the mat-select (e.g. using flex box) after its rendered, the template[cdk-connected-overlay] does not update its minWidth and keeps the initial minWidth every time its opened.

This issue happens because the cdk-connected-overlay sets the width, minWidth, etc etc only once and never updates it again.

StackBlitz replication: https://stackblitz.com/edit/angular-material2-issue-jbtqvx

Proposed fix in PR

We just need to update the size of the overlay-directive when _attachOverlay() is called if its already been created.

Replaces #6489

emoralesb05 · 2017-12-01T20:04:59Z

@kara @crisbeto let me know if i need to do anything else

hopefully, this can be merged now since this PR chain has been opened since march hahaha 😄

crisbeto

Can you also rename the PR? It's not really a feature on the select, but rather a bugfix on the overlay. It can be something along the lines of fix(overlay): dimension not updated after init.

crisbeto · 2017-12-01T20:03:38Z

src/lib/select/select.spec.ts

+      it('should set the width of the overlay based on the trigger and resize', async(() => {
+        trigger.style.width = '200px';
+        fixture.detectChanges();
+        fixture.whenStable().then(() => {


In general we're moving away from async tests, because they tend to be slower and flakier. Can you try to turn this into a fakeAsync one? All you have to do is replace the fixture.whenStable callbacks with a flush call.

Cool, will do that

emoralesb05 · 2017-12-01T20:19:49Z

@crisbeto Done, renamed the commit and replaced async with fakeAsync 👍

crisbeto · 2017-12-01T20:26:17Z

src/lib/select/select.spec.ts

+      it('should set the width of the overlay based on the trigger and resize', fakeAsync(() => {
+        trigger.style.width = '200px';
+        fixture.detectChanges();
+        fixture.whenStable().then(() => {


You can't use fixture.whenStable inside a fakeAsync test. What ends up happening is that the test will complete before the callback is invoked. What I meant before is taking something like this:

fixture.detectChanges(); fixture.whenStable(() => { // do stuff });

And turning it into this:

fixture.detectChanges(); flush(); // do stuff

I updated that already, missed it before haha

It seems like you have one left over.

oh snap, my bad... thats what i get for trying to do it fast haha.. fixing it

now its done for sure! 😄

crisbeto

LGTM

andrewseguin · 2017-12-13T21:44:15Z

Can you check the errors on this?

googlebot · 2017-12-13T22:32:42Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

emoralesb05 · 2017-12-13T22:37:50Z

Trying to fix the commits haha sorry about that.

emoralesb05 · 2017-12-13T22:42:24Z

Ok, now everything is rebased. Hoping that helps with the CI tests. Does the cla:yes tag need to be added manually now? or how do i trigger that again? @andrewseguin

emoralesb05 · 2017-12-13T23:14:24Z

Hmm.. im still not sure why the other tests are failing.. cant seem to figure out why would my code change affect those tests.. any ideas @andrewseguin @crisbeto ?

BatStak · 2018-01-08T16:40:02Z

Is there any news for this issue?

jelbourn · 2018-01-23T07:07:22Z

@emoralesb05 could you rebase this PR?

emoralesb05 · 2018-01-23T18:50:09Z

Sure, gonna try doing it today @jelbourn 😄

crisbeto · 2018-01-27T10:18:08Z

@emoralesb05 are you going to resubmit the PR? Otherwise I don't mind fixing it and it may be easier for me to get it through.

emoralesb05 · 2018-01-28T17:44:35Z

Sorry @crisbeto forgot to push after the rebase.

There is a unit test issue i'm seeing with tooltip but it seems unrelated to the commit since it was failing when i ran it in master.

Hopefully, we can merge this PR.. and no hard feelings if its easier to close this one and just fix it yourself @crisbeto haha its been opened for sooooo long that i just want to see that fixed.

emoralesb05 · 2018-01-31T19:30:42Z

@crisbeto @jelbourn anything else needed for this?

crisbeto · 2018-02-01T19:21:59Z

I'm not sure why the Bazel check is failing, but it shouldn't be because of the changes in this PR. Do you have an idea @jelbourn?

jelbourn · 2018-02-01T22:14:54Z

Looks like a flake

emoralesb05 · 2018-02-07T18:04:48Z

Can we merge this then? @crisbeto @jelbourn 😄

mmalerba · 2018-02-07T18:16:51Z

@emoralesb05 there's a process we have to follow. we first run a presubmit against google's codebase and watch for any test failures, once all the tests look good it can be merged

emoralesb05 · 2018-02-07T23:14:23Z

So do we need to trigger the tests again @mmalerba ??

mmalerba · 2018-02-08T04:18:56Z

nope, nothing for you to do, I just need to do the presubmit

angular-automatic-lock-bot · 2019-09-08T07:02:27Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

emoralesb05 requested review from crisbeto, jelbourn and kara as code owners December 1, 2017 19:59

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 1, 2017

emoralesb05 mentioned this pull request Dec 1, 2017

feat(select): update the trigger width and overlay state when select is opened #6489

Closed

emoralesb05 changed the title ~~feat(select): update the trigger width and overlay state when select is opened~~ feat(select): update overlay state when select is opened Dec 1, 2017

crisbeto reviewed Dec 1, 2017

View reviewed changes

crisbeto self-assigned this Dec 1, 2017

emoralesb05 changed the title ~~feat(select): update overlay state when select is opened~~ fix(overlay): dimension not updated after init Dec 1, 2017

crisbeto reviewed Dec 1, 2017

View reviewed changes

crisbeto approved these changes Dec 1, 2017

View reviewed changes

crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 1, 2017

mmalerba added the target: patch This PR is targeted for the next patch release label Dec 6, 2017

emoralesb05 requested review from amcdnl, andrewseguin, devversion, josephperrott, mmalerba and tinayuangao as code owners December 13, 2017 22:16

googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Dec 13, 2017

andrewseguin added the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Dec 13, 2017

andrewseguin removed the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Dec 13, 2017

vthinkxie mentioned this pull request Dec 18, 2017

ant-select-dropdown's width won't change when nz-select width change NG-ZORRO/ng-zorro-antd#779

Closed

emoralesb05 closed this Jan 27, 2018

fix(overlay): dimension not updated after init

0ba8ceb

emoralesb05 reopened this Jan 28, 2018

jelbourn removed the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Feb 1, 2018

mmalerba merged commit 7fbdc0d into angular:master Feb 8, 2018

emoralesb05 deleted the select-width-update branch February 8, 2018 21:46

mmalerba pushed a commit that referenced this pull request Feb 8, 2018

fix(overlay): dimension not updated after init (#8765)

c36b512

tinayuangao pushed a commit that referenced this pull request Feb 9, 2018

fix(overlay): dimension not updated after init (#8765)

8df2c81

benjamincharity mentioned this pull request Feb 16, 2018

Select: The dropdown doesn't resize when the window is resized GetTerminus/terminus-ui#588

Closed

crisbeto mentioned this pull request May 6, 2018

Issue with mat-select inside a div with padding and browser resize #8329

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019

fix(overlay): dimension not updated after init #8765

fix(overlay): dimension not updated after init #8765

Uh oh!

Conversation

emoralesb05 commented Dec 1, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed fix in PR

Uh oh!

emoralesb05 commented Dec 1, 2017

Uh oh!

crisbeto left a comment

Choose a reason for hiding this comment

Uh oh!

crisbeto Dec 1, 2017

Choose a reason for hiding this comment

Uh oh!

emoralesb05 Dec 1, 2017

Choose a reason for hiding this comment

Uh oh!

emoralesb05 commented Dec 1, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

crisbeto Dec 1, 2017

Choose a reason for hiding this comment

Uh oh!

emoralesb05 Dec 1, 2017

Choose a reason for hiding this comment

Uh oh!

crisbeto Dec 1, 2017

Choose a reason for hiding this comment

Uh oh!

emoralesb05 Dec 1, 2017

Choose a reason for hiding this comment

Uh oh!

emoralesb05 Dec 1, 2017

Choose a reason for hiding this comment

Uh oh!

crisbeto left a comment

Choose a reason for hiding this comment

Uh oh!

andrewseguin commented Dec 13, 2017

Uh oh!

googlebot commented Dec 13, 2017

Uh oh!

emoralesb05 commented Dec 13, 2017

Uh oh!

emoralesb05 commented Dec 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

emoralesb05 commented Dec 13, 2017

Uh oh!

BatStak commented Jan 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jelbourn commented Jan 23, 2018

Uh oh!

emoralesb05 commented Jan 23, 2018

Uh oh!

crisbeto commented Jan 27, 2018

Uh oh!

emoralesb05 commented Jan 28, 2018

Uh oh!

emoralesb05 commented Jan 31, 2018

Uh oh!

crisbeto commented Feb 1, 2018

Uh oh!

jelbourn commented Feb 1, 2018

Uh oh!

emoralesb05 commented Feb 7, 2018

Uh oh!

mmalerba commented Feb 7, 2018

Uh oh!

emoralesb05 commented Feb 7, 2018

Uh oh!

mmalerba commented Feb 8, 2018

Uh oh!

angular-automatic-lock-bot bot commented Sep 8, 2019

Uh oh!

Reviewers

Assignees

emoralesb05 commented Dec 1, 2017 •

edited

Loading

emoralesb05 commented Dec 1, 2017 •

edited

Loading

emoralesb05 commented Dec 13, 2017 •

edited

Loading

BatStak commented Jan 8, 2018 •

edited

Loading