chore(tooltip): unit test failures #8385
Conversation
crisbeto
commented
Nov 12, 2017
crisbeto
commented
- Fixes a regression in the tooltip that was introduced by 0719c38 which caused the tests to fail.
- Avoids issues in the future where failures in some tooltip tests can cause Jasmine to throw the browser into an infinite loop by trying to stringify a circular object.
googlebot
added
the
cla: yes
|
|
||
| // Dispose of the tooltip when the overlay is detached. | ||
| overlayRef.detachments().subscribe(() => { | ||
| merge(this._tooltipInstance!.afterHidden(), overlayRef.detachments()).subscribe(() => { |
There was a problem hiding this comment.
Move the ! up to the assignment for tooltipInstance?
There was a problem hiding this comment.
TS isn't smart enough to figure it out when it's being assigned to a property, it only works for variables.
src/lib/tooltip/tooltip.spec.ts
Outdated
|
|
||
| it('should show and hide the tooltip', fakeAsync(() => { | ||
| expect(tooltipDirective._tooltipInstance).toBeUndefined(); | ||
| expect(!!tooltipDirective._tooltipInstance).toBe(false); |
There was a problem hiding this comment.
Can you make it just one place that does this? Something like a method getTooltipInstance? That way it's easy to add a comment in one place that explains it rather than repeating !! without explanation
* Fixes a regression in the tooltip that was introduced by 0719c38 which caused the tests to fail. * Avoids issues in the future where failures in some tooltip tests can cause Jasmine to throw the browser into an infinite loop by trying to stringify a circular object.
crisbeto
force-pushed
the
tooltip-detach-regression
branch
from
95b4ea3 to
223c49b
Compare
|
Addressed the feedback @jelbourn. |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
