Skip to content

fix(datepicker): calendar overlapping input when in a fallback position #8099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2017
Merged

fix(datepicker): calendar overlapping input when in a fallback position #8099

merged 1 commit into from
Dec 1, 2017

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 28, 2017

  • Prevents datepickers that are in a fallback position from overlapping their input by adding an offset.
  • Fixes some inconsistent brace spacing.

@crisbeto crisbeto requested a review from mmalerba as a code owner October 28, 2017 17:00
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 28, 2017
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 14, 2017
@crisbeto crisbeto force-pushed the datepicker-fallback-overlap branch 2 times, most recently from b44bc52 to ba7afb5 Compare November 20, 2017 20:43
@tinayuangao
Copy link
Contributor

tinayuangao commented Nov 29, 2017

@crisbeto please rebase. Thanks!

@crisbeto
fix(datepicker): calendar overlapping input when in a fallback position
0ebc001 
* Prevents datepickers that are in a fallback position from overlapping their input by adding an offset.
* Fixes some inconsistent brace spacing.
@crisbeto crisbeto force-pushed the datepicker-fallback-overlap branch from ba7afb5 to 0ebc001 Compare November 29, 2017 19:31
@crisbeto
Copy link
Member Author

crisbeto commented Nov 29, 2017

Rebased @tinayuangao.

@tinayuangao tinayuangao merged commit e5b7afe into angular:master Dec 1, 2017
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@mmalerba mmalerba

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto @tinayuangao @googlebot @mmalerba