Skip to content

Conversation

@crisbeto
Copy link
Member

Fixes dialogs that hit their max-width no longer being centered in IE11. This seems like a regression introduced after 57f19cd.

@crisbeto crisbeto requested a review from jelbourn as a code owner October 26, 2017 19:26
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 26, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Oct 26, 2017
Fixes dialogs that hit their `max-width` no longer being centered in IE11. This seems like a regression introduced after 57f19cd.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Dec 6, 2017
@andrewseguin andrewseguin added the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Dec 13, 2017
@andrewseguin andrewseguin merged commit 65b63bb into angular:master Jan 12, 2018
andrewseguin pushed a commit to andrewseguin/components that referenced this pull request Jan 12, 2018
)

Fixes dialogs that hit their `max-width` no longer being centered in IE11. This seems like a regression introduced after 57f19cd.
andrewseguin added a commit to andrewseguin/components that referenced this pull request Jan 16, 2018
@andrewseguin
Copy link
Contributor

Okay, bad news :(

This PR ended up having an unexpected issue in a screenshot diff that I think needs to be resolved before we merge this back in.

To reproduce this in the demo app, go to the overlay-demo.ts and change one of the overlays so that it uses the position strategy this.overlay.position().global().right('0px')

Start the demo app and observe that the cdk-overlay-0 element has dimensions 102px x 73px

Now, revert your changes: on cdk-global-overlay-wrapper, remove flex-direction: column; align-items: flex-end; and add back justify-content: flex-end)

See now that the dimensions of cdk-overlay-0 are larger and extend the full height of the screen.

This was a problem in one app where their content assumed that they could use height: 100% and use overlay to make a sliding panel.

@crisbeto
Copy link
Member Author

Let's park this one until #9236 gets in, I think it has some changes that could help with the initial issue.

andrewseguin pushed a commit that referenced this pull request Jan 17, 2018
Fixes dialogs that hit their `max-width` no longer being centered in IE11. This seems like a regression introduced after 57f19cd.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants