Skip to content

build: autocomplete test failure in iOS Safari #7906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2017
Merged

build: autocomplete test failure in iOS Safari #7906

merged 1 commit into from
Oct 20, 2017

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 19, 2017 •
edited
Loading

Fixes an autocomplete test failure in iOS Safari 10.

@crisbeto crisbeto added the in progress This issue is currently in progress label Oct 19, 2017
@crisbeto crisbeto self-assigned this Oct 19, 2017
@crisbeto crisbeto requested a review from kara as a code owner October 19, 2017 19:08
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 19, 2017
@crisbeto crisbeto added pr: merge safe and removed in progress This issue is currently in progress labels Oct 19, 2017
@crisbeto crisbeto assigned tinayuangao and unassigned crisbeto Oct 19, 2017
@crisbeto crisbeto changed the title wip: autocomplete test failure in iOS Safari build: autocomplete test failure in iOS Safari Oct 19, 2017
@tinayuangao
Copy link
Contributor

tinayuangao commented Oct 19, 2017

LGTM

kara
kara approved these changes Oct 20, 2017
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Oct 20, 2017
@tinayuangao tinayuangao merged commit 5c6e3df into angular:master Oct 20, 2017
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@kara kara kara approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tinayuangao tinayuangao

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto @tinayuangao @kara @googlebot