fix(scroll): Replace references to scrollableReferences #7752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The demo app won't build due to PR angular#7630.
googlebot
added
the
cla: yes
ppham27
referenced
this pull request
Oct 12, 2017
* Adds the `ancestorScrolled` method that allows for the consumer to subscribe to scroll events coming from the element's parent scrollables. * The `scrolled` and `ancestorScrolled` streams now expose the scrollable that was scrolled. BREAKING CHANGES: * The `getScrollContainers` method has been renamed to `getAncestorScrollContainers` to better describe what it does. * The `ScrollDispatcher.scrollableReferences` property has been renamed to `scrollContainers`. * The `ScrollDispatcher.scrollableContainsElement` method has been removed. * The `Scrollable` class has been renamed to `CdkScrollable` for consistency.
crisbeto
approved these changes
Oct 13, 2017
Member
crisbeto
left a comment
crisbeto
left a comment
There was a problem hiding this comment.
LGTM, seems like something that slipped through during rebasing.
crisbeto
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The demo app won't build due to PR #7630.