refactor(scroll-dispatcher): API improvements #7630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P1
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
* Adds the `ancestorScrolled` method that allows for the consumer to subscribe to scroll events coming from the element's parent scrollables. * The `scrolled` and `ancestorScrolled` streams now expose the scrollable that was scrolled. BREAKING CHANGES: * The `getScrollContainers` method has been renamed to `getAncestorScrollContainers` to better describe what it does. * The `ScrollDispatcher.scrollableReferences` property has been renamed to `scrollContainers`. * The `ScrollDispatcher.scrollableContainsElement` method has been removed. * The `Scrollable` class has been renamed to `CdkScrollable` for consistency.
crisbeto
force-pushed
the
scroll-dispatcher-improvements
branch
from
350559a to
5d263b6
Compare
ppham27
added a commit
to ppham27/material2
that referenced
this pull request
Oct 12, 2017
The demo app won't build due to PR angular#7630.
andrewseguin
pushed a commit
that referenced
this pull request
Oct 13, 2017
The demo app won't build due to PR #7630.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ancestorScrolledmethod that allows for the consumer to subscribe to scroll events coming from the element's parent scrollables.scrolledandancestorScrolledstreams now expose the scrollable that was scrolled.BREAKING CHANGES:
getScrollContainersmethod has been renamed togetAncestorScrollContainersto better describe what it does.ScrollDispatcher.scrollableReferencesproperty has been renamed toscrollContainers.ScrollDispatcher.scrollableContainsElementmethod has been removed.Scrollableclass has been renamed toCdkScrollablefor consistency.