Skip to content

Conversation

@jelbourn
Copy link
Member

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 21, 2017
CHANGELOG.md Outdated
* `FocusOriginMonitor` has been renamed to `FocusMonitor` and moved to `@angular/cdk`.
* **chip-list:** - The outputs `select` and `deselect` have been removed in favor of a single
`onSelectionChange` output.
* **viewport-ruler:** Previously the `ScrollDispatcher.scrolled` subscription would react both on
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this got merged, there were some issues with that PR. It might have been merged and then reverted

CHANGELOG.md Outdated
```ts
overlayContainer.getContainerElement().classList.add('my-theme-class');
```
* `FocusOriginMonitor` has been renamed to `FocusMonitor`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already mentioned above

CHANGELOG.md Outdated
```
* `FocusOriginMonitor` has been renamed to `FocusMonitor`.
* Angular Material now requires Angular 4.4.1 or greater
* **viewport-ruler:** Previously the `ScrollDispatcher.scrolled` subscription would react both on
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already mentioned above, and I don't think it was actually merged yet

Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typos

CHANGELOG.md Outdated
### Breaking changes

* Angular Material now requires **Angular 4.4.3 or greater**
* MaterialModule has been removed. (#6803) ([cf1ece0](https://github.com/angular/material2/commit/cf1ece0))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: MaterialModule instead of MaterialModule. Put deprecation notice note in front of the PR # instead of behind? Easier to see.

CHANGELOG.md Outdated
* Angular Material now requires **Angular 4.4.3 or greater**
* MaterialModule has been removed. (#6803) ([cf1ece0](https://github.com/angular/material2/commit/cf1ece0))
[See the deprecation notice from beta.3 for more information](https://github.com/angular/material2/blob/master/CHANGELOG.md#200-beta3-cesium-cephalopod-2017-04-07).
* `MdCoreModule` has been removed. Most of its functionality has been move to `@angular/cdk` over
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move -> moved

CHANGELOG.md Outdated
* MaterialModule has been removed. (#6803) ([cf1ece0](https://github.com/angular/material2/commit/cf1ece0))
[See the deprecation notice from beta.3 for more information](https://github.com/angular/material2/blob/master/CHANGELOG.md#200-beta3-cesium-cephalopod-2017-04-07).
* `MdCoreModule` has been removed. Most of its functionality has been move to `@angular/cdk` over
the last few released.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

released -> releases

CHANGELOG.md Outdated
* `MdCoreModule` has been removed. Most of its functionality has been move to `@angular/cdk` over
the last few released.
* `FocusOriginMonitor` has been renamed to `FocusMonitor` and moved to `@angular/cdk`.
* **chip-list:** - The outputs `select` and `deselect` have been removed in favor of a single
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove -

CHANGELOG.md Outdated
```ts
overlayContainer.getContainerElement().classList.add('my-theme-class');
```
* `FocusOriginMonitor` has been renamed to `FocusMonitor`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dupe of line 19. Remove?

CHANGELOG.md Outdated
overlayContainer.getContainerElement().classList.add('my-theme-class');
```
* `FocusOriginMonitor` has been renamed to `FocusMonitor`.
* Angular Material now requires Angular 4.4.1 or greater
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a dupe of line 14. Remove?

CHANGELOG.md Outdated
```
* `FocusOriginMonitor` has been renamed to `FocusMonitor`.
* Angular Material now requires Angular 4.4.1 or greater
* **viewport-ruler:** Previously the `ScrollDispatcher.scrolled` subscription would react both on
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dupe of line 22. Remove?

@jelbourn
Copy link
Member Author

Addressed comments

Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 3571f68 into angular:master Sep 21, 2017
@jelbourn jelbourn deleted the beta-11-again branch April 2, 2018 22:30
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants