Skip to content

Conversation

@tinayuangao
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 8, 2017
@tinayuangao tinayuangao added Accessibility This issue is related to accessibility (a11y) pr: needs review and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Aug 8, 2017
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 8, 2017
@@ -0,0 +1,14 @@
<section>
<h2>Home icon (Ligature from Material Icons font)</h2>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have examples for each of the accessibility use cases listed here: https://material.angular.io/components/icon/overview

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Changed to uses cases listed in https://material.angular.io/components/icon/overview

@@ -0,0 +1,17 @@
<section>
<h2>Fingerprint icon (Decorative icons)</h2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make this something like

<h2>Fingerprint status</h2>
<p>Showing a status message with a purely decorative icon</p>
<md-icon color="primary">fingerprint</md-icon>
Your fingerprint was recorded!

(similar structure for other examples)

<h2>Delete icon (Interactive icons) </h2>
<button md-icon-button aria-label="Delete" (click)="deleteIcon()">
<md-icon color="accent">delete</md-icon>
</button>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have an example with <a md-icon-button> as well

@tinayuangao
Copy link
Contributor Author

Added another example with <a md-icon-button>. PTAL. Thanks!

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Aug 9, 2017
@mmalerba mmalerba merged commit d48b957 into angular:master Aug 9, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants