build: properly lint tooling source code #6055
Conversation
* Fixes a glob that is responsible for IDE's TypeScript service and also for TSLint * Fixes strict null check errors in the screenshot app. Currently the app can't be compiled properly since strict null checks had been introduced there as well.
googlebot
added
the
cla: yes
| if (counter === snapshot.numChildren()) { | ||
| return true; | ||
| } | ||
| return ++counter === snapshot.numChildren(); |
There was a problem hiding this comment.
I prefer not to use increment/decrement expressions as part of a larger expression where the order of the increment/decrement would matter
(here and elsewhere)
There was a problem hiding this comment.
Not sure. I thought it's a pretty basic JavaScript syntax. I'm fine changing it if you prefer it though.
There was a problem hiding this comment.
Changed it. Please have another look.
There was a problem hiding this comment.
It's basic syntax in Java, C++, C#... and in all of those languages, I see this as potentially confusing.
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
Note: Two remaining lint issues coming from #6044