Skip to content

build: e2e failures and add missing rx operators to rollup config #5930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2017
Merged

build: e2e failures and add missing rx operators to rollup config #5930

merged 1 commit into from
Jul 21, 2017

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 21, 2017 •
edited
Loading

  • Fixes a component not being added to the examples module, causing the E2E task to fail.
  • Adds some operators that were missing from the Rollup config.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 21, 2017
@crisbeto
build: e2e failures and add missing rx operators to rollup config
962fb69 
* Fixes a component not being added to the examples module, causing the E2E task to fail.
* Adds some operators that were missing from the Rollup config.
@crisbeto crisbeto changed the title build: add missing rx operators to rollup config build: e2e failures and add missing rx operators to rollup config Jul 21, 2017
devversion
devversion approved these changes Jul 21, 2017
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jul 21, 2017
@kara kara merged commit 3676c2c into angular:master Jul 21, 2017
crisbeto added a commit to crisbeto/material2 that referenced this pull request Jul 22, 2017
@crisbeto
build: add tslint rule to verify rollup globals config
4a24929 
Adds a custom tslint rule that ensures that we've added all of the necessary external modules to the Rollup config. This is helpful, because forgetting to add a module will log a warning, but it won't break the build necessarily, which is why we occasionally need PRs like angular#5930.
@crisbeto crisbeto mentioned this pull request Jul 22, 2017
Merged
crisbeto added a commit to crisbeto/material2 that referenced this pull request Jul 22, 2017
@crisbeto
build: add tslint rule to verify rollup globals config
f769f72 
Adds a custom tslint rule that ensures that we've added all of the necessary external modules to the Rollup config. This is helpful, because forgetting to add a module will log a warning, but it won't break the build necessarily, which is why we occasionally need PRs like angular#5930.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Jul 22, 2017
@crisbeto
build: add tslint rule to verify rollup globals config
e724403 
Adds a custom tslint rule that ensures that we've added all of the necessary external modules to the Rollup config. This is helpful, because forgetting to add a module will log a warning, but it won't break the build necessarily, which is why we occasionally need PRs like angular#5930.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Jul 22, 2017
@crisbeto
build: add tslint rule to verify rollup globals config
6bf2ff1 
Adds a custom tslint rule that ensures that we've added all of the necessary external modules to the Rollup config. This is helpful, because forgetting to add a module will log a warning, but it won't break the build necessarily, which is why we occasionally need PRs like angular#5930.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Jul 26, 2017
@crisbeto
build: add tslint rule to verify rollup globals config
dd82287 
Adds a custom tslint rule that ensures that we've added all of the necessary external modules to the Rollup config. This is helpful, because forgetting to add a module will log a warning, but it won't break the build necessarily, which is why we occasionally need PRs like angular#5930.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Jul 27, 2017
@crisbeto
build: add tslint rule to verify rollup globals config
5c046de 
Adds a custom tslint rule that ensures that we've added all of the necessary external modules to the Rollup config. This is helpful, because forgetting to add a module will log a warning, but it won't break the build necessarily, which is why we occasionally need PRs like angular#5930.
andrewseguin pushed a commit to andrewseguin/components that referenced this pull request Jul 28, 2017
@crisbeto @andrewseguin
build: add tslint rule to verify rollup globals config
8176073 
Adds a custom tslint rule that ensures that we've added all of the necessary external modules to the Rollup config. This is helpful, because forgetting to add a module will log a warning, but it won't break the build necessarily, which is why we occasionally need PRs like angular#5930.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Jul 29, 2017
@crisbeto
build: add tslint rule to verify rollup globals config
321ee8b 
Adds a custom tslint rule that ensures that we've added all of the necessary external modules to the Rollup config. This is helpful, because forgetting to add a module will log a warning, but it won't break the build necessarily, which is why we occasionally need PRs like angular#5930.
tinayuangao pushed a commit that referenced this pull request Jul 31, 2017
@crisbeto @tinayuangao
build: add tslint rule to verify rollup globals config (#5963)
d9e6f75 
Adds a custom tslint rule that ensures that we've added all of the necessary external modules to the Rollup config. This is helpful, because forgetting to add a module will log a warning, but it won't break the build necessarily, which is why we occasionally need PRs like #5930.
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 6, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@jelbourn jelbourn

@devversion devversion

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@crisbeto @devversion @jelbourn @kara @googlebot