Skip to content

docs(demos): autocomplete examples #5787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2017
Merged

docs(demos): autocomplete examples #5787

merged 1 commit into from
Jul 27, 2017

Conversation

@amcdnl
Copy link
Contributor

@amcdnl amcdnl commented Jul 15, 2017

Adds basic set of demos for autocomplete component:

  • Basic
  • Filtering
  • Display Value
  • Better overview example

This is a new PR in follow-up to #5464 merge issues.

@amcdnl amcdnl requested a review from jelbourn July 15, 2017 17:06
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 15, 2017
@amcdnl amcdnl self-assigned this Jul 15, 2017
@amcdnl amcdnl mentioned this pull request Jul 15, 2017
Closed
@willshowell willshowell mentioned this pull request Jul 21, 2017
Closed
jelbourn
jelbourn approved these changes Jul 25, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 25, 2017
willshowell
willshowell reviewed Jul 25, 2017
View reviewed changes
src/material-examples/autocomplete-display/autocomplete-display-example.css
@@ -0,0 +1,7 @@
.example-form {
width: 500px;
}
Copy link
Contributor

@willshowell willshowell Jul 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amcdnl Think you could add max-width: 100% before it merges, here and elsewhere? If not, I'll be happy to in subsequent pr.

#5839

Copy link
Contributor Author

@amcdnl amcdnl Jul 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willshowell - I was thinking about going through and removing all these fixed widths since it causes responsive issues. I'd like to do that in a separate PR.

@andrewseguin andrewseguin merged commit 40072a1 into angular:master Jul 27, 2017
@amcdnl amcdnl deleted the autocomplete-demos2 branch July 29, 2017 15:16
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 6, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

+1 more reviewer

@willshowell willshowell willshowell left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@amcdnl amcdnl

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@amcdnl @jelbourn @willshowell @googlebot @andrewseguin