Skip to content

fix(input): placeholder covering value when using OnPush #5660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2017
Merged

fix(input): placeholder covering value when using OnPush #5660

merged 2 commits into from
Jul 14, 2017

Conversation

@willshowell
Copy link
Contributor

@willshowell willshowell commented Jul 10, 2017

Fixes #3005

cc @mmalerba

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 10, 2017
@jelbourn jelbourn requested review from crisbeto and mmalerba July 10, 2017 22:28
crisbeto
crisbeto approved these changes Jul 11, 2017
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 11, 2017
@mmalerba
Copy link
Contributor

mmalerba commented Jul 11, 2017

Can you make the demo OnPush so I can test this? I seem to remember trying something similar and it didn't quite work

@willshowell
Copy link
Contributor Author

willshowell commented Jul 11, 2017

@mmalerba done, PTAL

@crisbeto crisbeto mentioned this pull request Jul 12, 2017
Merged
@jelbourn jelbourn merged commit 219a8ae into angular:master Jul 14, 2017
@willshowell willshowell deleted the fix/input-placeholder-onpush branch July 28, 2017 15:42
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 6, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

input placeholder covers value when using OnPush detection strategy

5 participants

@willshowell @mmalerba @crisbeto @jelbourn @googlebot