Skip to content

chore(demo-app): fix tabs being unrecognizable in dark theme #5214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2017
Merged

chore(demo-app): fix tabs being unrecognizable in dark theme #5214

merged 1 commit into from
Jun 22, 2017

Conversation

@devversion
Copy link
Member

@devversion devversion commented Jun 19, 2017

  • The tabs demo is the only demo that still overwrites the associated component with CSS that makes it not testable in dark themes (through the dark theme switcher)
  • This commit replaces those CSS selectors with CSS that works in dark themes too

@devversion
chore(demo-app): fix tabs being unrecognizable in dark theme
f3861c3 
* The tabs demo is the only demo that still overwrites the associated component with CSS that makes it not testable in dark themes (through the dark theme switcher)
* This commit replaces those CSS selectors with CSS that works in dark themes too
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 19, 2017
jelbourn
jelbourn approved these changes Jun 19, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jun 19, 2017
@jelbourn jelbourn merged commit 0ea2533 into angular:master Jun 22, 2017
@devversion devversion deleted the chore/dark-tabs-demo-app branch November 11, 2017 10:23
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devversion @jelbourn @googlebot