Skip to content

build: missing cdk release output #4811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2017
Merged

build: missing cdk release output #4811

merged 1 commit into from
May 25, 2017

Conversation

@devversion
Copy link
Member

@devversion devversion commented May 25, 2017

For the publish artifacts script the CDK release output didn't build. The CDK release output is necessary since it will be also published to cdk-builds.

@devversion
build: missing cdk release output
b7bc7ea 
For the publish artifacts script the CDK release output didn't build. The CDK release output is necessary since it will be also published to cdk-builds.
@devversion devversion requested a review from jelbourn May 25, 2017 21:15
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 25, 2017
jelbourn
jelbourn approved these changes May 25, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 25, 2017
@tinayuangao tinayuangao merged commit 1fce545 into angular:master May 25, 2017
@devversion devversion deleted the build/artifacts-cdk branch November 11, 2017 10:23
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@devversion @jelbourn @googlebot @tinayuangao