refactor(multiple): convert components to theme inspection API #27688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
force-pushed
the
inspection-api-conversion
branch
4 times, most recently
from
4519bc9 to
e573974
Compare
mmalerba
force-pushed
the
inspection-api-conversion
branch
6 times, most recently
from
d1139da to
821a9ee
Compare
mmalerba
changed the title
Converts the following components to use the new theme inspection API under the hood: card, core, form-field, optgroup, option, progress-bar, pseudo-checkbox, ripple As a side effect, this allows us to start cleaning up all of the theme normalization logic that previously had to be baked into every theme mixin. The goal once all components are converted is that apps can opt themselves into only supporting the inspection API to access theme values and throw errors on all attempts to access the theme via other means. This will identify usages of the theme that need to be updated to work with M3.
mmalerba
force-pushed
the
inspection-api-conversion
branch
from
e055771 to
9e6c198
Compare
mmalerba
requested review from
andrewseguin,
crisbeto,
devversion,
jelbourn and
josephperrott
as code owners
andrewseguin
approved these changes
Aug 25, 2023
crisbeto
approved these changes
Aug 25, 2023
mmalerba
added a commit
to mmalerba/components
that referenced
this pull request
Aug 27, 2023
Converts: input, list, radio, slide-toggle, slider. See related PR angular#27688 for more context.
mmalerba
added a commit
to mmalerba/components
that referenced
this pull request
Aug 28, 2023
Converts: input, list, radio, slide-toggle, slider. See related PR angular#27688 for more context.
mmalerba
added a commit
to mmalerba/components
that referenced
this pull request
Aug 28, 2023
Converts: input, list, checkbox, radio, slide-toggle, slider. See related PR angular#27688 for more context.
mmalerba
added a commit
that referenced
this pull request
Aug 29, 2023
… 2) (#27713) * refactor(multiple): convert components to theme inspection API Converts: input, list, checkbox, radio, slide-toggle, slider. See related PR #27688 for more context. * refactor(multiple): convert components to theme inspection API Converts: button, icon-button, fab, paginator. * build: fix lint
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts the following components to use the new theme inspection API
under the hood: card, core, form-field, optgroup, option, progress-bar,
pseudo-checkbox, ripple
As a side effect, this allows us to start cleaning up all of the
theme normalization logic that previously had to be baked into every
theme mixin.
The goal once all components are converted is that apps can opt
themselves into only supporting the inspection API to access theme
values and throw errors on all attempts to access the theme via other
means. This will identify usages of the theme that need to be updated to
work with M3.