feat(cdk/tree): allow use of nested node with flattened data, and vice versa #25899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| childrenAccessor = (dataNode: NestedFoodNode) => timer(100).pipe(mapTo(dataNode.children ?? [])); | ||
|
|
||
| dataSource = new ArrayDataSource(NESTED_DATA); |
Contributor
There was a problem hiding this comment.
Nit: Can be readonly?
| export class CdkTreeNestedLevelAccessorExample { | ||
| levelAccessor = (dataNode: FlatFoodNode) => dataNode.level; | ||
|
|
||
| dataSource = new ArrayDataSource(FLAT_DATA); |
Contributor
There was a problem hiding this comment.
Nit: can be readonly?
BobobUnicorn
force-pushed
the
cdk-tree-redesign-nested-translation
branch
5 times, most recently
from
f471445 to
e875ce5
Compare
…nderNodeChanges` private
BobobUnicorn
force-pushed
the
cdk-tree-redesign-nested-translation
branch
2 times, most recently
from
b379b80 to
7d0b6a2
Compare
jelbourn
reviewed
Feb 24, 2023
| * | ||
| * This controls what selection of data the tree will render. | ||
| */ | ||
| // NB: we're unable to determine this ourselves; Angular's ContentChildren |
| */ | ||
| // NB: we're unable to determine this ourselves; Angular's ContentChildren | ||
| // unfortunately does not pick up the necessary information. | ||
| @Input() nodeType?: 'flat' | 'nested'; |
Member
There was a problem hiding this comment.
Why is this necessary at the node level? I would think that this is only needed at the entire tree level
| .pipe(takeUntil(this._onDestroy)) | ||
| .subscribe(data => this.renderNodeChanges(data)); | ||
| .pipe( | ||
| switchMap(data => this._convertChildren(data)), |
Member
There was a problem hiding this comment.
I don't quite follow what's going on with this conversation here
Comment on lines
+688
to
+691
| // The only situations where we have to convert children types is when | ||
| // they're mismatched; i.e. if the tree is using a childrenAccessor and the | ||
| // nodes are flat, or if the tree is using a levelAccessor and the nodes are | ||
| // nested. |
Member
There was a problem hiding this comment.
I don't quite follow how this situation would come about- I would think we would only want to support either flat or nested for the entire free instance
BobobUnicorn
force-pushed
the
cdk-tree-redesign-nested-translation
branch
from
7d0b6a2 to
19df7fb
Compare
andrewseguin
force-pushed
the
cdk-tree-revamp
branch
2 times, most recently
from
565eb38 to
fbe321d
Compare
BobobUnicorn
force-pushed
the
cdk-tree-redesign-nested-translation
branch
from
19df7fb to
79d0b69
Compare
BobobUnicorn
force-pushed
the
cdk-tree-redesign-nested-translation
branch
from
79d0b69 to
f0e4ca6
Compare
BobobUnicorn
force-pushed
the
cdk-tree-redesign-nested-translation
branch
from
f0e4ca6 to
bdbd7dd
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #25729. Followed by #26585.