fix(material-experimental/mdc-checkbox): remove extra a11y tree node … …for the <label/> #24907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarend
added
Accessibility
zarend
force-pushed
the
checkbox-label-a11y-tree-2
branch
from
2f60f2b to
40b345d
Compare
zarend
changed the title
zarend
force-pushed
the
checkbox-label-a11y-tree-2
branch
2 times, most recently
from
317cc09 to
5401dd8
Compare
zarend
added
the
dev-app preview
|
Deployed dev-app to: https://ng-comp-dev--pr-24907-59d0c3ceea4ecc0c1cc89c0b003e39d1-0camutqd.web.app |
crisbeto
reviewed
May 13, 2022
zarend
force-pushed
the
checkbox-label-a11y-tree-2
branch
2 times, most recently
from
66b4fe6 to
cfe526c
Compare
crisbeto
reviewed
May 14, 2022
Member
crisbeto
left a comment
crisbeto
left a comment
There was a problem hiding this comment.
The change LGTM, but the lint check is failing and my approval will be invalidated when it's fixed.
zarend
force-pushed
the
checkbox-label-a11y-tree-2
branch
from
cfe526c to
c67de2a
Compare
zarend
force-pushed
the
checkbox-label-a11y-tree-2
branch
from
c67de2a to
84aae0c
Compare
mmalerba
previously approved these changes
May 17, 2022
zarend
force-pushed
the
checkbox-label-a11y-tree-2
branch
from
84aae0c to
8413a3a
Compare
…for the <label/> In the mdc checkbox component, removes the click handler on <label/> and handles stoping propgation of clicks on the label in the label's parent. This removes the extra a11y tree node on the label and fixes TalkBack having an extra navigation stop (angular#14385). A11y tree before this commit. It has an un-necessary node, which coresponds to the `<label>` element. ``` - Generic - Checkbox, "Field A" - Textlabel, "Field A" ``` A11y tree with this commit applied ``` - Generic - Checkbox, "Field A" ``` fixes angular#14385
zarend
force-pushed
the
checkbox-label-a11y-tree-2
branch
from
8413a3a to
59d0c3c
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the mdc checkbox component, removes the click handler on
and handles stoping propgation of clicks on the label in the label's
parent. This removes the extra a11y tree node on the label and fixes
TalkBack having an extra navigation stop (#14385).
A11y tree before this commit. It has an un-necessary node, which
corresponds to the
<label>element.A11y tree with this commit applied
fixes #14385