fix(material/autocomplete): always emit closed event #24642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the autocomplete does not emit a `closed` event if the user clicks outside the input field after having entered a string that did not match any option. Moreover, when entering a valid string after an invalid one, the `opened` event is emitted again without a previous `closed` event. This PR ensures that a `closed` event is emitted every time the panel is closed
mhaertwig
force-pushed
the
fix-autocomplete-events
branch
from
857527d to
5e707d5
Compare
andrewseguin
approved these changes
Mar 24, 2022
Contributor
andrewseguin
left a comment
andrewseguin
left a comment
There was a problem hiding this comment.
Seems right to me (and thanks for adding the tests), but I suspect this may break some tests internally due to expectations on when the events are fired
andrewseguin
added
action: merge
forsti0506
pushed a commit
to forsti0506/components
that referenced
this pull request
Apr 3, 2022
Currently, the autocomplete does not emit a `closed` event if the user clicks outside the input field after having entered a string that did not match any option. Moreover, when entering a valid string after an invalid one, the `opened` event is emitted again without a previous `closed` event. This PR ensures that a `closed` event is emitted every time the panel is closed
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the autocomplete does not emit a
closedevent if the user clicks outside the input field after having entered a string that did not match any option. Moreover, when entering a valid string after an invalid one, theopenedevent is emitted again without a previousclosedevent.autocomplete-no-closed.mp4
Demo: https://stackblitz.com/edit/angular-dvitxy?file=src/app/autocomplete-auto-active-first-option-example.html
This PR ensures that a closed event is emitted every time the panel is closed.