Skip to content

docs(cdk/accordion): define string type for cdkaccordion property id #24640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2022
Merged

docs(cdk/accordion): define string type for cdkaccordion property id #24640

merged 1 commit into from
Mar 25, 2022

Conversation

@seth0027
Copy link
Contributor

@seth0027 seth0027 commented Mar 22, 2022

Fixes a bug in accordian/api documentation in CdkAccordian where id property is not loosley defined.
This is because id property is not explicitly defined as string.

Fixes #24639

@seth0027 seth0027 requested a review from andrewseguin as a code owner March 22, 2022 05:03
@crisbeto
Copy link
Member

crisbeto commented Mar 22, 2022

The change looks good, but you have to change the cdk/accordian to cdk/accordion in the commit message title.

@seth0027 seth0027 changed the title docs(cdk/accordian): define string type for cdkaccordian property id docs(cdk/accordion): define string type for cdkaccordion property id Mar 22, 2022
@seth0027
docs(cdk/accordion): define string type for cdkaccordion property id
5cbb1f8 
Fixes a bug in accordion/api documentation in CdkAccordion where id property is not loosley defined.
This is because id property is not explicitly defined as string.

Fixes angular#24639
@seth0027 seth0027 force-pushed the docs-bug-accordian branch from f235352 to 5cbb1f8 Compare March 22, 2022 17:44
@seth0027
Copy link
Contributor Author

seth0027 commented Mar 22, 2022

The change looks good, but you have to change the cdk/accordian to cdk/accordion in the commit message title.

Done

crisbeto
crisbeto approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 24, 2022
@andrewseguin andrewseguin merged commit 853d2cc into angular:master Mar 25, 2022
andrewseguin pushed a commit that referenced this pull request Mar 25, 2022
@seth0027 @andrewseguin
docs(cdk/accordion): define string type for cdkaccordion property id (#…
2656a03 
…24640)

Fixes a bug in accordion/api documentation in CdkAccordion where id property is not loosley defined.
This is because id property is not explicitly defined as string.

Fixes #24639

(cherry picked from commit 853d2cc)
@seth0027 seth0027 deleted the docs-bug-accordian branch March 26, 2022 00:21
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Apr 3, 2022
@seth0027
docs(cdk/accordion): define string type for cdkaccordion property id (a…
cbdac44 
…ngular#24640)

Fixes a bug in accordion/api documentation in CdkAccordion where id property is not loosley defined.
This is because id property is not explicitly defined as string.

Fixes angular#24639
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Apr 26, 2022

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

docs-bug(cdk/accordion): accordion/api cdkaccordion property id type should be string

3 participants

@seth0027 @crisbeto @andrewseguin