build: fix standalone release checks failing due to missing global ReleaseAction instance
#24509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eleaseAction` instance
Fixes the standalone release checks running outside of the `.ng-dev` config load, which
comes with the `global.ReleaseAction`. In standalone checks this variable is not
defined and therefore currently causes errors like:
```
/.ng-dev/release.ts:14
const actionProto = (global as any).ReleaseAction.prototype;
^
TypeError: Cannot read properties of undefined (reading 'prototype')
at Object.<anonymous>
```
We can fallback to the imported `ReleaseAction` constructor object if the global reference
is not provided. In such cases the monkey-patching is a noop anyway.
devversion
added
merge safe
target: patch
amysorto
approved these changes
Mar 2, 2022
amysorto
pushed a commit
that referenced
this pull request
Mar 2, 2022
…eleaseAction` instance (#24509) Fixes the standalone release checks running outside of the `.ng-dev` config load, which comes with the `global.ReleaseAction`. In standalone checks this variable is not defined and therefore currently causes errors like: ``` /.ng-dev/release.ts:14 const actionProto = (global as any).ReleaseAction.prototype; ^ TypeError: Cannot read properties of undefined (reading 'prototype') at Object.<anonymous> ``` We can fallback to the imported `ReleaseAction` constructor object if the global reference is not provided. In such cases the monkey-patching is a noop anyway. (cherry picked from commit 55549cc)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the standalone release checks running outside of the
.ng-devconfig load (whichcomes with the
global.ReleaseAction). In standalone checks this variable is notdefined and therefore currently causes errors like:
We can fallback to the imported
ReleaseActionconstructor object if the global referenceis not provided. In such cases the monkey-patching is a noop anyway.