Skip to content

fix(material/schematics): don't replace variables contained within the names of other variables in theming API migration #24021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2021
Merged

fix(material/schematics): don't replace variables contained within the names of other variables in theming API migration #24021

merged 1 commit into from
Dec 14, 2021

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 27, 2021

Fixes that the theming API migration would replace the $swift-ease-in inside a variable like $swift-ease-in-duration, because the regex would partially match the name.

Fixes #24013.

@crisbeto
fix(material/schematics): don't replace variables contained within th…
aaf5a54 
…e names of other variables in theming API migration

Fixes that the theming API migration would replace the `$swift-ease-in` inside a variable like `$swift-ease-in-duration`, because the regex would partially match the name.

Fixes angular#24013.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Nov 27, 2021
@crisbeto crisbeto requested a review from devversion November 27, 2021 11:34
@crisbeto crisbeto requested a review from jelbourn as a code owner November 27, 2021 11:34
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 27, 2021
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 27, 2021
@amysorto amysorto merged commit 7468588 into angular:master Dec 14, 2021
amysorto pushed a commit that referenced this pull request Dec 14, 2021
@crisbeto @amysorto
fix(material/schematics): don't replace variables contained within th…
0629a2c 
…e names of other variables in theming API migration (#24021)

Fixes that the theming API migration would replace the `$swift-ease-in` inside a variable like `$swift-ease-in-duration`, because the regex would partially match the name.

Fixes #24013.

(cherry picked from commit 7468588)
This was referenced Jan 1, 2022
Closed
Open
Closed
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jan 14, 2022

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(material/schematics): v12 theming API migration should not rename variables appended with extra characters

3 participants

@crisbeto @devversion @amysorto