Skip to content

fix(progress-spinner): fix color input on md-spinner #2396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2017
Merged

fix(progress-spinner): fix color input on md-spinner #2396

merged 1 commit into from
Jan 4, 2017

Conversation

@devversion
Copy link
Member

@devversion devversion commented Dec 24, 2016

  • Makes color application similar to all other components (consistency & preparation for Share methods to set the theme color classes #2394)
  • Fixes that the the md-spinner doesn't support a color binding
  • Fixes the missing documentation for the color and value inputs (See here)
  • Removes the unused changeDetectorRef from the constructor DI

Fixes #2393

@devversion devversion requested a review from jelbourn December 24, 2016 12:54
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 24, 2016
@devversion devversion changed the title fix(prgoress-spinner): fix color input on md-spinner fix(progress-spinner): fix color input on md-spinner Dec 24, 2016
@devversion
fix(progress-spinner): fix color input on md-spinner
bdf4aef 
* Makes color application dynamic by moving it to a getter / setter. (similar to all other components & makes it easier to share the code in the future)
* Now the `md-spinner` can also have a `color` binding.
* Fixes the missing documentation for the `color` and `value` inputs
* Removes the unused `changeDetectorRef` from the constructor DI

Fixes angular#2393
@jelbourn
Copy link
Member

jelbourn commented Dec 28, 2016

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 28, 2016
@kara kara merged commit 6cb6576 into angular:master Jan 4, 2017
@devversion devversion deleted the fix/spinner-color branch January 4, 2017 18:33
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 6, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

md-spinner: color binding not working

4 participants

@devversion @jelbourn @kara @googlebot