Skip to content

Conversation

@devversion
Copy link
Member

Removes unused code from legacy tooling and View Engine compilation
within Bazel.

Also the clang-format file is removed given that we run prettier
in the whole repository now.

@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels Nov 4, 2021
@devversion devversion requested a review from a team as a code owner November 4, 2021 16:58
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 4, 2021
@devversion devversion changed the title build: remove unused code from legacy tooling and View Engine build: remove unused code from legacy tooling and View Engine build Nov 4, 2021
…eftovers

Removes unused code from legacy tooling and View Engine compilation
within Bazel.

Also the clang-format file is removed given that we run prettier
in the whole repository now.
@devversion devversion force-pushed the build/remove-unused-code branch from 0a9ebba to 087569e Compare November 4, 2021 17:00
@devversion devversion changed the title build: remove unused code from legacy tooling and View Engine build build: remove unused code from legacy tooling and remove view-engine leftovers Nov 4, 2021
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Nov 4, 2021
@amysorto amysorto merged commit be9abca into angular:master Nov 5, 2021
amysorto pushed a commit that referenced this pull request Nov 5, 2021
…leftovers (#23899)

* build: remove unused code from legacy tooling and remove viewengine leftovers

Removes unused code from legacy tooling and View Engine compilation
within Bazel.

Also the clang-format file is removed given that we run prettier
in the whole repository now.

* fixup! build: remove unused code from legacy tooling and remove viewengine leftovers

ds

(cherry picked from commit be9abca)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants