From fc40af6c87fc3953f782710ad8d80ba25e7487e5 Mon Sep 17 00:00:00 2001 From: Kristiyan Kostadinov Date: Thu, 21 Oct 2021 13:51:41 +0200 Subject: [PATCH] build: handle top-level packages in API approval script Fixes that the `approve-api` script was generating the wrong Bazel target for `google-maps` and `youtube-player`. Fixes #23782. --- scripts/approve-api-golden.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/scripts/approve-api-golden.js b/scripts/approve-api-golden.js index 64c3e1ef8db4..b3c42d7ca32f 100644 --- a/scripts/approve-api-golden.js +++ b/scripts/approve-api-golden.js @@ -26,9 +26,8 @@ if (!packageNameGuess.result) { } const [packageName, ...entryPointTail] = packageNameGuess.result.split('/'); -const apiGoldenTargetName = `//tools/public_api_guard:${packageName}/${entryPointTail.join( - '-', -)}.md_api.accept`; +const suffix = entryPointTail.length ? entryPointTail.join('-') : packageName; +const apiGoldenTargetName = `//tools/public_api_guard:${packageName}/${suffix}.md_api.accept`; // ShellJS should exit if any command fails. shelljs.set('-e');