Skip to content

build: handle top-level packages in API approval script #23808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2021
Merged

build: handle top-level packages in API approval script #23808

merged 1 commit into from
Oct 21, 2021

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 21, 2021

Fixes that the approve-api script was generating the wrong Bazel target for google-maps and youtube-player.

Fixes #23782.

@crisbeto
build: handle top-level packages in API approval script
fc40af6 
Fixes that the `approve-api` script was generating the wrong Bazel target for `google-maps` and `youtube-player`.

Fixes angular#23782.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: rc This PR is targeted for the next release-candidate labels Oct 21, 2021
@crisbeto crisbeto requested a review from devversion October 21, 2021 11:52
@crisbeto crisbeto requested a review from a team as a code owner October 21, 2021 11:52
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 21, 2021
@josephperrott josephperrott removed the request for review from a team October 21, 2021 16:21
josephperrott
josephperrott approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 21, 2021
@wagnermaciel wagnermaciel merged commit 15dbc95 into angular:master Oct 21, 2021
wagnermaciel pushed a commit that referenced this pull request Oct 21, 2021
@crisbeto @wagnermaciel
build: handle top-level packages in API approval script (#23808)
77a54d5 
Fixes that the `approve-api` script was generating the wrong Bazel target for `google-maps` and `youtube-player`.

Fixes #23782.

(cherry picked from commit 15dbc95)
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Oct 22, 2021
@crisbeto
build: handle top-level packages in API approval script (angular#23808)
05bc3bb 
Fixes that the `approve-api` script was generating the wrong Bazel target for `google-maps` and `youtube-player`.

Fixes angular#23782.
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Nov 21, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Help: Error while passing ci/circleci: api_golden_checks for Google Maps.

4 participants

@crisbeto @devversion @josephperrott @wagnermaciel