build: update MDC to latest canary and simplify bazel setup #23235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
devversion
force-pushed
the
build/various-cleanups
branch
from
13a6a7b to
b2a8048
Compare
devversion
added
merge safe
target: patch
devversion
requested review from
a team,
andrewseguin and
mmalerba
as code owners
devversion
added
the
merge: preserve commits
mmalerba
added
action: merge
mmalerba
force-pushed
the
build/various-cleanups
branch
from
b2a8048 to
70bd7e2
Compare
Removes an unused Bazel macro that has been used in the past for processing Sass files.
Replaces our custom ES5 JS module extraction rule with a configurable one that has recently been added to the dev-infra package.
Updates MDC to the latest canary version which contains: material-components/material-components-web@9808de0. This change allows us to remove the RequireJS configuration files. While removing these files, we also simplify our Bazel Karma test suite setup so that no MDC UMD bundles need to be specified manually. This was cumbersome and especially time-consuming because the old setup also required developers to manually determine which transitive MDC UMD bundles are needed. The new setup always includes all MDC UMD files in Karma web test suites. Ideally this would not be needed at all, but due to a limitation in `rules_nodejs`, the MDC UMD files cannot be resolved automatically from the `deps`. We could archive this using a custom Bazel rule (confirmed in some experiments that it is possible), but this rule will become quite complex and seem like a bandaid. Eventually the Bazel NodeJS rules should be able to determine named AMD files out-of-the box when installing the node modules.
Removes the `expand_template` Bazel rule with a similar rule that is provided by the shared dev-infra package.
mmalerba
force-pushed
the
build/various-cleanups
branch
from
70bd7e2 to
7e16ea5
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.