Skip to content

Conversation

@subsetdht
Copy link
Contributor

Fixes a bug in the example of Angular Material mat-table with columns generated via ngFor.
The fix changes the tags over to native table selectors, which brings the example into alignment
with other examples of mat-table usage and allows for Angular Material formatting to apply.

Fixes a bug in the example of Angular Material `mat-table` with columns generated via ngFor.
The fix changes the tags over to native table selectors, which brings the example into alignment
with other examples of `mat-table` usage and allows for Angular Material formatting to apply.
@subsetdht subsetdht requested a review from andrewseguin as a code owner July 13, 2021 01:06
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 13, 2021
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Jul 13, 2021
@amysorto amysorto merged commit 0aa223f into angular:master Jul 15, 2021
amysorto pushed a commit that referenced this pull request Jul 15, 2021
Fixes a bug in the example of Angular Material `mat-table` with columns generated via ngFor.
The fix changes the tags over to native table selectors, which brings the example into alignment
with other examples of `mat-table` usage and allows for Angular Material formatting to apply.

(cherry picked from commit 0aa223f)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants