Skip to content

test(cdk/a11y): use DI to construct modality checker #23030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2021
Merged

test(cdk/a11y): use DI to construct modality checker #23030

merged 1 commit into from
Jun 22, 2021

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 21, 2021

Currently the InputModalityChecker tests construct the object manually which is brittle. These changes switch using DI to construct it automatically.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Jun 21, 2021
@crisbeto crisbeto requested a review from devversion June 21, 2021 15:57
@crisbeto crisbeto requested a review from jelbourn as a code owner June 21, 2021 15:57
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 21, 2021
devversion
devversion approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@crisbeto
test(cdk/a11y): use DI to construct modality checker
3d4740f 
Currently the `InputModalityChecker` tests construct the object manually which is brittle. These changes switch using DI to construct it automatically.
@crisbeto crisbeto force-pushed the modality-checker-tests branch from 6f8b2a1 to 3d4740f Compare June 21, 2021 16:25
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jun 21, 2021
jelbourn
jelbourn approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmalerba mmalerba added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jun 22, 2021
@mmalerba mmalerba merged commit 2f695c4 into angular:master Jun 22, 2021
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jul 23, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto @jelbourn @devversion @mmalerba