Skip to content

Conversation

@devversion
Copy link
Member

  • Adds a basic documentation of the public properties like in the checkbox component.

Note: Still documenting tabIndex (regardless of being filtered), because this would allow us in the future to easily remove the filtering and just have it documented. Also just for consistency.

@jelbourn The documentation might be sometimes very bare, but for now it should be good (most of the stuff is similar in the md-checkbox)

@devversion devversion requested a review from jelbourn December 17, 2016 08:46
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 17, 2016
@jelbourn
Copy link
Member

LGTM, thanks!

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 18, 2016
@jelbourn
Copy link
Member

@devversion can you rebase this?

* Adds a basic documentation of the public properties like in the checkbox component.
@devversion devversion force-pushed the chore/slide-toggle-docs branch from 46ae64b to 87df977 Compare December 20, 2016 20:56
@devversion
Copy link
Member Author

@jelbourn Done

@jelbourn jelbourn merged commit 75cd73b into angular:master Dec 20, 2016
@devversion devversion deleted the chore/slide-toggle-docs branch December 21, 2016 10:23
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants