Skip to content

feat(material-expeirmental/mdc-form-field): separate out text and icon prefixes/suffixes #21956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 26, 2021
Merged

feat(material-expeirmental/mdc-form-field): separate out text and icon prefixes/suffixes #21956

merged 4 commits into from
Feb 26, 2021

Conversation

@mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Feb 19, 2021

No description provided.

@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release labels Feb 19, 2021
@mmalerba mmalerba requested a review from jelbourn February 19, 2021 02:03
@mmalerba mmalerba requested a review from devversion as a code owner February 19, 2021 02:03
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 19, 2021
crisbeto
crisbeto reviewed Feb 19, 2021
View reviewed changes
@mmalerba
Copy link
Contributor Author

mmalerba commented Feb 24, 2021

rebased, PTAL

crisbeto
crisbeto approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Feb 25, 2021
@wagnermaciel wagnermaciel added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Feb 26, 2021
@wagnermaciel wagnermaciel merged commit db6511b into angular:master Feb 26, 2021
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Mar 29, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

@devversion devversion Awaiting requested review from devversion

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mmalerba @jelbourn @crisbeto @wagnermaciel