Skip to content

docs(material/select): update accessibility information on roles #21372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2020
Merged

docs(material/select): update accessibility information on roles #21372

merged 1 commit into from
Dec 17, 2020

Conversation

@macjohnny
Copy link
Contributor

@macjohnny macjohnny commented Dec 16, 2020

see #20082
and

components/src/material/select/select.ts

Line 1107 in 3c37e4b

'role': 'combobox',

@macjohnny macjohnny requested a review from crisbeto as a code owner December 16, 2020 09:37
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 16, 2020
@macjohnny macjohnny changed the title docs(select): update accessibility information on roles docs(material/select): update accessibility information on roles Dec 16, 2020
crisbeto
crisbeto approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Dec 16, 2020
@mmalerba mmalerba merged commit 98f6fd9 into angular:master Dec 17, 2020
mmalerba pushed a commit that referenced this pull request Dec 17, 2020
@macjohnny @mmalerba
docs(material/select): update accessibility information on roles (#21372
9cd2f47 
)

(cherry picked from commit 98f6fd9)
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Jan 14, 2021
@macjohnny @wagnermaciel
docs(material/select): update accessibility information on roles (ang…
281d92f 
…ular#21372)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jan 17, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@macjohnny @crisbeto @mmalerba