test: add class with e2e test utilities #2070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Member
Author
|
This will need a little more work once #2051 is merged. |
crisbeto
force-pushed
the
2025/e2e-utils
branch
2 times, most recently
from
6184c90 to
34743ce
Compare
crisbeto
force-pushed
the
2025/e2e-utils
branch
from
34743ce to
31a943c
Compare
Member
Author
|
Should be good to go now. |
crisbeto
force-pushed
the
2025/e2e-utils
branch
from
3fc52a8 to
3823135
Compare
Member
Author
|
Can we get this one through @jelbourn? It should make writing e2e tests a little simpler. |
jelbourn
reviewed
Jan 4, 2017
e2e/utils.e2e.ts
Outdated
| /** | ||
| * A set of utility functions for writing E2E tests. | ||
| */ | ||
| export class E2EUtils { |
Member
There was a problem hiding this comment.
Couple of things I want to rearrange here:
- I think we should just export / use the standalone functions without them being in a class (similar to
coerceBooleanPropertyorapplyCssTransformin core). - I want to avoid having one big "utils" file and instead divide the functions into more tightly-scoped files. I was thinking we could have something
util/asserts.ts,util/geometry.ts,util/actions.ts, andutil/query.ts
* Adds a class that simplifies some common and hard to remember Protractor expressions. * Refactors the existing tests to use the new utilities. Fixes angular#2025.
crisbeto
force-pushed
the
2025/e2e-utils
branch
from
2b847b2 to
55eac99
Compare
Member
Author
|
Split the E2E class into a few smaller files @jelbourn. |
jelbourn
approved these changes
Jan 14, 2017
Member
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
LGTM, just add the "merge ready" label after rebase
# Conflicts: # e2e/components/button/button.e2e.ts # e2e/components/dialog/dialog.e2e.ts # e2e/components/menu/menu-page.ts
kara
pushed a commit
to kara/material2
that referenced
this pull request
Jan 20, 2017
* test: add class with e2e test utilities * Adds a class that simplifies some common and hard to remember Protractor expressions. * Refactors the existing tests to use the new utilities. Fixes angular#2025. * Add types to the e2e utils and fix the selector on the dialog tests. * Remove unnecessary rounding. * Remove `any` cast. * Simplify the slide toggle tests. * Split the E2E utils class into smaller files. * Fix a leftover.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2025.