refactor: handle home/end presses through key manager #19955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
crisbeto
requested review from
andrewseguin,
devversion,
jelbourn and
mmalerba
as code owners
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
19834/home-end-refactor
branch
from
8d20b5d to
4d37216
Compare
devversion
approved these changes
Jul 13, 2020
|
|
||
| const event = createKeyboardEvent('keydown', END); | ||
| Object.defineProperty(event, 'shiftKey', { get: () => true }); | ||
| Object.defineProperty(event, 'altKey', { get: () => true }); |
Member
There was a problem hiding this comment.
Just for context: We had to change this test because previously we didn't allow HOME/END with any modifier keys pressed. Now though we will start supporting those keys with the SHIFT modifier key, right?
Member
Author
There was a problem hiding this comment.
Yes, exactly. I did it since, from what I can tell, home and end don't do much with a modifier anyway.
Contributor
|
@crisbeto Seems like this PR has some merge conflicts |
Member
Author
|
Rebased. |
crisbeto
force-pushed
the
19834/home-end-refactor
branch
from
4d37216 to
5f8ccca
Compare
crisbeto
force-pushed
the
19834/home-end-refactor
branch
from
5f8ccca to
a9d52ca
Compare
Based on top of angular#19834, changes the places where we were handling home/end to go through the key manager. Also allows `withHomeAndEnd` to be turned off, similarly to what we're doing with the other methods.
crisbeto
force-pushed
the
19834/home-end-refactor
branch
from
a9d52ca to
23432bd
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #19834, changes the places where we were handling home/end to go through the key manager.
Also allows
withHomeAndEndto be turned off, similarly to what we're doing with the other methods.cc @vanessanschmitt