Skip to content

Conversation

@annieyw
Copy link
Contributor

@annieyw annieyw commented Jun 17, 2020

Remove static code snippets in material docs and replace them with embedded examples in compact view.
Add regions in component examples.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 17, 2020
@annieyw annieyw requested a review from atscott June 17, 2020 23:33
@annieyw annieyw force-pushed the panel branch 4 times, most recently from 638b0cc to dc54533 Compare June 18, 2020 22:41
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from one nit.

</ng-template>
</mat-horizontal-stepper>
```
<!-- example({"example":"stepper-states",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually have a space between after the colon in object literals, e.g. "example": "steper-states".

@crisbeto crisbeto added docs This issue is related to documentation lgtm target: patch This PR is targeted for the next patch release labels Jun 19, 2020
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jun 19, 2020
@mmalerba mmalerba merged commit b2577a1 into angular:master Jun 19, 2020
mmalerba pushed a commit that referenced this pull request Jun 19, 2020
…md to reflect new API (panel, stepper) (#19680)

* expansion panel

* stepper

* add space in obj literal
@annieyw annieyw deleted the panel branch June 19, 2020 22:28
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants