Skip to content

fix(datepicker): strong focus indication in calendar always shown #19304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2020
Merged

fix(datepicker): strong focus indication in calendar always shown #19304

merged 1 commit into from
May 13, 2020

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented May 10, 2020

We ended up using the same pseudo elements for the strong focus indication and the date range, causing the focus indication to always be shown. These changes move the focus indicator to a different element.

@crisbeto
fix(datepicker): strong focus indication in calendar always shown
7916fc1 
We ended up using the same pseudo elements for the strong focus indication and the date range, causing the focus indication to always be shown. These changes move the focus indicator to a different element.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels May 10, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 10, 2020
@zelliott
Copy link
Collaborator

zelliott commented May 11, 2020

Nice catch @crisbeto! I didn't know this component configuration existed. LGTM

@crisbeto
Copy link
Member Author

crisbeto commented May 11, 2020

We just merged it in last week.

jelbourn
jelbourn approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels May 11, 2020
@mmalerba mmalerba merged commit 4eee81a into angular:master May 13, 2020
@zelliott zelliott mentioned this pull request May 13, 2020
Merged
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jun 13, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@mmalerba mmalerba

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@crisbeto @zelliott @jelbourn @googlebot @mmalerba