Skip to content

Revert "fix(radio): clicks not landing correctly in some cases on Chrome (#18357)" #18820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2020
Merged

Revert "fix(radio): clicks not landing correctly in some cases on Chrome (#18357)" #18820

merged 1 commit into from
Mar 13, 2020

Conversation

@andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented Mar 13, 2020 •
edited
Loading

Had problems internally when users wanted to focus an <input> inside of a radio option after that option is selected. Please commit the changes to a new PR so we can continue working on it

This reverts commit fe29835.

@andrewseguin andrewseguin requested a review from crisbeto March 13, 2020 17:49
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 13, 2020
crisbeto
crisbeto approved these changes Mar 13, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added lgtm action: merge The PR is ready for merge by the caretaker labels Mar 13, 2020
@andrewseguin andrewseguin merged commit b5b3c8a into angular:master Mar 13, 2020
andrewseguin added a commit that referenced this pull request Mar 13, 2020
@andrewseguin
Revert "fix(radio): clicks not landing correctly in some cases on Chr…
7634bb8 
…ome (#18357)" (#18820)

This reverts commit fe29835.

(cherry picked from commit b5b3c8a)
@andrewseguin
Copy link
Contributor Author

andrewseguin commented Mar 13, 2020

Here's a stripped down version of what I found users doing https://stackblitz.com/edit/angular-k9v2jr?file=src/app/radio-overview-example.ts

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Apr 13, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion Awaiting requested review from devversion

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewseguin @crisbeto @googlebot