fix(material-experimetal/mdc-form-field): account for breaking changes in MDC #18795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
crisbeto
requested review from
a team,
devversion,
jelbourn and
mmalerba
as code owners
googlebot
added
the
cla: yes
devversion
approved these changes
Mar 11, 2020
Member
devversion
left a comment
devversion
left a comment
There was a problem hiding this comment.
LGTM in general. Thx! One minor comment.
src/material-experimental/mdc-form-field/_mdc-text-field-structure-overrides.scss
Outdated
Show resolved
Hide resolved
…s in MDC In material-components/material-components-web@8639c26 MDC reworked how their heights and paddings are set up, causing a compilation error on our end. These changes account for the new setup.
crisbeto
force-pushed
the
mdc-form-field-breaking-change
branch
from
df1ca1a to
3ce65bc
Compare
Contributor
|
Thanks for this! 😀 |
andrewseguin
pushed a commit
that referenced
this pull request
Mar 12, 2020
…s in MDC (#18795) In material-components/material-components-web@8639c26 MDC reworked how their heights and paddings are set up, causing a compilation error on our end. These changes account for the new setup. (cherry picked from commit b2e8691)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In material-components/material-components-web@8639c26 MDC reworked how their heights and paddings are set up, causing a compilation error on our end. These changes account for the new setup.