Skip to content

docs(tooltip): scrollable example not working #18661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2020
Merged

docs(tooltip): scrollable example not working #18661

merged 1 commit into from
Mar 4, 2020

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 29, 2020

Fixes the example that shows how a tooltip works with a CdkScrollable not working, because we hadn't imported the module.

Also fixes a few places that were using the old way of writing the selector.

@crisbeto
docs(tooltip): scrollable example not working
595b560 
Fixes the example that shows how a tooltip works with a `CdkScrollable` not working, because we hadn't imported the module.

Also fixes a few places that were using the old way of writing the selector.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: merge safe target: patch This PR is targeted for the next patch release labels Feb 29, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 29, 2020
jelbourn
jelbourn approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 3, 2020
@mmalerba mmalerba merged commit c2c7f44 into angular:master Mar 4, 2020
mmalerba added a commit that referenced this pull request Mar 6, 2020
@mmalerba
docs(tooltip): scrollable example not working (#18661)
0e80863 
Fixes the example that shows how a tooltip works with a `CdkScrollable` not working, because we hadn't imported the module.

Also fixes a few places that were using the old way of writing the selector.
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Apr 4, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto @jelbourn @googlebot @mmalerba