fix(material-experimental/mdc-radio): able to focus disabled radio button via click #18584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
…tton via click We have an existing fix for the regular radio button at angular#15499, but since it hasn't been merged yet, it got transferred to the MDC-based one. Fixes users being able to focus a disabled radio button by clicking on it. The issue comes from us preserving the -1 tabindex, even if the button is disabled.
crisbeto
force-pushed
the
mdc-radio-disabled-focusable
branch
from
521594f to
989866f
Compare
jelbourn
pushed a commit
that referenced
this pull request
Mar 3, 2020
…tton via click (#18584) We have an existing fix for the regular radio button at #15499, but since it hasn't been merged yet, it got transferred to the MDC-based one. Fixes users being able to focus a disabled radio button by clicking on it. The issue comes from us preserving the -1 tabindex, even if the button is disabled. (cherry picked from commit 7ba45d9)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an existing fix for the regular radio button at #15499, but since it hasn't been merged yet, it got transferred to the MDC-based one.
Fixes users being able to focus a disabled radio button by clicking on it. The issue comes from us preserving the -1 tabindex, even if the button is disabled.