Skip to content

fix(material-experimental/slider): add slider mixin to main theme mixin #18384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 12, 2020
Merged

fix(material-experimental/slider): add slider mixin to main theme mixin #18384

merged 3 commits into from
Mar 12, 2020

Conversation

@andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented Feb 4, 2020

No description provided.

@andrewseguin andrewseguin added the target: patch This PR is targeted for the next patch release label Feb 4, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 4, 2020
jelbourn
jelbourn approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 4, 2020
@andrewseguin andrewseguin force-pushed the mdc-slider-fix branch 2 times, most recently from 25b1614 to 95dd9ae Compare February 27, 2020 18:10
@mmalerba
Copy link
Contributor

mmalerba commented Mar 4, 2020

@andrewseguin looks like there's some CI issues

@devversion devversion added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Mar 9, 2020
@devversion
Copy link
Member

devversion commented Mar 9, 2020

Adding P3 since I'd need this for the density feature branch.

@andrewseguin andrewseguin merged commit 2b937f1 into angular:master Mar 12, 2020
andrewseguin added a commit that referenced this pull request Mar 12, 2020
@andrewseguin
fix(material-experimental/slider): add slider mixin to main theme mix…
3b777eb 
…in (#18384)

* fix(material-experimental/slider): add slider mixin to main theme mixin

* include universal app

* fix universal

(cherry picked from commit 2b937f1)
@snyk-bot snyk-bot mentioned this pull request Mar 19, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 28, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 8, 2020
Merged
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Apr 12, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@andrewseguin @mmalerba @devversion @jelbourn @googlebot