Skip to content

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 5, 2019

Fixes the shared test functions for the dialog and progress spinner harnesses ignoring their module parameter and always using the Material module.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: merge safe target: patch This PR is targeted for the next patch release labels Nov 5, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner November 5, 2019 23:02
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 5, 2019
Fixes the shared test functions for the dialog and progress spinner harnesses ignoring their `module` parameter and always using the Material module.
@crisbeto crisbeto force-pushed the shared-harness-tests-module branch from 8a43dbd to 6cb27e5 Compare November 5, 2019 23:08
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 5, 2019
@mmalerba mmalerba merged commit 69ccd34 into angular:master Nov 5, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants