Skip to content

build: tests should not fail if stylesheets contain quotes #17251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2019
Merged

build: tests should not fail if stylesheets contain quotes #17251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions tools/defaults.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,12 +197,14 @@ def ng_web_test_suite(deps = [], static_css = [], bootstrap = [], tags = [], **k
output_to_bindir = True,
cmd = """
files=($(locations %s))
css_content=$$(cat $${files[0]})
js_template="var cssElement = document.createElement('style'); \
cssElement.type = 'text/css'; \
cssElement.innerHTML = '$$css_content'; \
document.head.appendChild(cssElement);"

# Escape all double-quotes so that the content can be safely inlined into the
# JS template. Note that it needs to be escaped a second time because the string
# will be evaluated first in Bash and will then be stored in the JS output.
css_content=$$(cat $${files[0]} | sed 's/"/\\\\"/g')
js_template='var cssElement = document.createElement("style"); \
cssElement.type = "text/css"; \
cssElement.innerHTML = "'"$$css_content"'"; \
document.head.appendChild(cssElement);'
echo $$js_template > $@
""" % css_label,
)
Expand Down