build: add workaround for bug breaking ts_library hermeticity #17225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patches `@bazel/typescript` to not be non-hermetic. We need to work around this because it impacts the Bazel development workflow significantly if file changes sometimes need a `bazel clean` (basically breaking incrementality). Issue is reported with in-depth details: bazel-contrib/rules_nodejs#1208.
googlebot
added
the
cla: yes
devversion
added
pr: merge safe
target: patch
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches
@bazel/typescriptto not be non-hermetic. We need towork around this because it impacts the Bazel development workflow
significantly if file changes sometimes need a
bazel clean(basically breaking incrementality).
Issue is reported with in-depth details: bazel-contrib/rules_nodejs#1208. I wanted to go for a fix, but apparently it involves a bigger discussion and is probably blocked by G3 syncs, so a workaround through postinstall seems reasonable for now.