refactor(google-maps): remove unnecessary modules #17165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
google-maps-cleanup
branch
from
bc2ee2a to
e4fed5e
Compare
Member
|
I think @mbehrlich was planning to do this; you two should coordinate on Slack |
Collaborator
|
It looks like this was made before I submitted the pull request for the Info Window component. There will likely be some merge conflicts, and I think you will need to make some changes to incorporate the info window component as well. |
crisbeto
force-pushed
the
google-maps-cleanup
branch
from
e4fed5e to
059951c
Compare
Member
Author
|
Rebased and applied the same changes to the info window module. |
crisbeto
force-pushed
the
google-maps-cleanup
branch
from
059951c to
53c3d6c
Compare
Removes the `GoogleMapModule` and `MapMarkerModule` since they're redundant.
crisbeto
force-pushed
the
google-maps-cleanup
branch
from
53c3d6c to
389f3cf
Compare
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
GoogleMapModuleandMapMarkerModulesince they're redundant.