Skip to content

refactor(dialog): allow matDialogClose on non-button nodes #16603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2019
Merged

refactor(dialog): allow matDialogClose on non-button nodes #16603

merged 1 commit into from
Aug 21, 2019

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 24, 2019

Loosens up the selector on MatDialogClose so that it can be added on everything, not just buttons.

Fixes #16597.

@crisbeto
refactor(dialog): allow matDialogClose on non-button nodes
95292dd 
Loosens up the selector on `MatDialogClose` so that it can be added on everything, not just buttons.

Fixes angular#16597.
@crisbeto crisbeto added P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release labels Jul 24, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner July 24, 2019 19:57
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 24, 2019
jelbourn
jelbourn approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 24, 2019
@michael-vasyliv
Copy link

michael-vasyliv commented Jul 30, 2019

@crisbeto could you also update doc https://material.angular.io/components/dialog/api#MatDialogClose?

@crisbeto
Copy link
Member Author

crisbeto commented Aug 4, 2019

The doc should update itself automatically once we release this change.

@michael-vasyliv
Copy link

michael-vasyliv commented Aug 5, 2019

@crisbeto thanks for clarification.

@andrewseguin andrewseguin merged commit 42b3f52 into angular:master Aug 21, 2019
andrewseguin pushed a commit that referenced this pull request Aug 26, 2019
@crisbeto @andrewseguin
refactor(dialog): allow matDialogClose on non-button nodes (#16603)
4306e63 
Loosens up the selector on `MatDialogClose` so that it can be added on everything, not just buttons.

Fixes #16597.

(cherry picked from commit 42b3f52)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 21, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Close a dialog (from @angular/material/dialog) on any element

5 participants

@crisbeto @michael-vasyliv @jelbourn @googlebot @andrewseguin